Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ElementWiseSum #1183

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Adding ElementWiseSum #1183

merged 1 commit into from
Jul 5, 2023

Conversation

marcromeyn
Copy link
Contributor

Goals ⚽

This PR introduces ElementWiseSum, similar to the class we have in tensorflow. This class is used by models like WideAndDeep & DeepFM.

@marcromeyn marcromeyn added enhancement New feature or request area/pytorch labels Jul 5, 2023
@marcromeyn marcromeyn self-assigned this Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1183

@marcromeyn marcromeyn marked this pull request as ready for review July 5, 2023 15:16
@edknv edknv merged commit 8c6bf05 into main Jul 5, 2023
41 checks passed
@edknv edknv deleted the torch/element-wise-sum branch July 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

@gabrielspmoreira gabrielspmoreira Awaiting requested review from gabrielspmoreira

@oliverholworthy oliverholworthy Awaiting requested review from oliverholworthy

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch enhancement New feature or request status/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcromeyn @edknv